FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is
Effort is max
Files
org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to l1 in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 359 | Medium |
| Dead store to l2 in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 360 | Medium |
| Dead store to s2 in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 358 | Medium |
| Dead store to l in org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator.slurpRaw(byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 286 | Medium |
| org.apache.hadoop.chukwa.ChukwaArchiveKey$Comparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 258-370 | Medium |
org.apache.hadoop.chukwa.ChunkImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.ChunkImpl.PROTOCOL_VERSION isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 34 | High |
org.apache.hadoop.chukwa.analysis.salsa.fsm.DataNodeClientTraceMapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.DataNodeClientTraceMapper.parseClientTraceDetailed(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 151 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.DataNodeClientTraceMapper.parseClientTraceDetailed(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 107 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.DataNodeClientTraceMapper.FSM_CRK_ReduceType isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 48 | High |
| Method call in org.apache.hadoop.chukwa.analysis.salsa.fsm.DataNodeClientTraceMapper.parseClientTraceDetailed(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter, ArrayList) passes null for nonnull parameter of new String(String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 184 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 405 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 419 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 438 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 444 | High |
org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_blockread(ChukwaRecord, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 101 | Medium |
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_blockwrite(ChukwaRecord, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 253 | Medium |
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_map(ChukwaRecord, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 125 | Medium |
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_redreducer(ChukwaRecord, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 231 | Medium |
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_redshufwait(ChukwaRecord, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 183 | Medium |
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_redsort(ChukwaRecord, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 207 | Medium |
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_shuffle(ChukwaRecord, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 159 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_blockread(ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 99 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_blockwrite(ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 251 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_map(ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 123 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_redreducer(ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 229 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_redshufwait(ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 181 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_redsort(ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 205 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.addStitchingFields_shuffle(ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 157 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.reduce(ChukwaRecordKey, Iterator, OutputCollector, Reporter) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 343 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.NON_COUNTER_KEYS should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 78 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.JCDF_EDGE_TIME isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 82 | High |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.JCDF_EDGE_VOL isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 83 | High |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.JCDF_ID1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 80 | High |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.JCDF_ID2 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 81 | High |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMBuilder$FSMReducer.JCDF_SEP isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 84 | High |
org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Equals method for org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry assumes the argument is of type FSMIntermedEntry | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 240 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 82 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.clone() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 263 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.generateUniqueID() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 106 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.getFriendlyID() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 95 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.getUniqueID() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 90 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.readFields(DataInput) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 179 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.toString() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 292 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.write(DataOutput) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 162 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 240-241 | High |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMIntermedEntry.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 240-241 | High |
org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMType
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMType.toString() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 30 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.FSMType.NAMES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 26 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.fsm.HDFSState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.analysis.salsa.fsm.HDFSState.toString() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 32 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.HDFSState.NAMES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 28 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper.expandReduceEnd(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter, FSMIntermedEntry) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 355 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper.expandReduceStart(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter, FSMIntermedEntry) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 284 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper.map(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 165 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper.populateRecord_MapCounters(FSMIntermedEntry, ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 87 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper.populateRecord_ReduceCounters(FSMIntermedEntry, ChukwaRecord, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 131 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper.FSM_CRK_ReduceType isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 50 | High |
| Nullcheck of tmpstring at line 222 of value previously dereferenced in org.apache.hadoop.chukwa.analysis.salsa.fsm.JobHistoryTaskDataMapper.map(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 222 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.fsm.MapRedState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.analysis.salsa.fsm.MapRedState.toString() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 35 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.MapRedState.NAMES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 30 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.fsm.ParseUtilities
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.analysis.salsa.fsm.ParseUtilities.extractHostnameFromTrackerName(String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 48 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.ParseUtilities.removeRackFromHostname(String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 62 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.ParseUtilities.splitChukwaRecordKey(String, FSMIntermedEntry, String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 38 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.fsm.StateType
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.analysis.salsa.fsm.StateType.toString() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 30 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.StateType.NAMES should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 26 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.fsm.TaskTrackerClientTraceMapper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.analysis.salsa.fsm.TaskTrackerClientTraceMapper.parseClientTraceDetailed(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter, ArrayList) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 152 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.TaskTrackerClientTraceMapper.parseClientTraceDetailed(ChukwaRecordKey, ChukwaRecord, OutputCollector, Reporter, ArrayList) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 106 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.fsm.TaskTrackerClientTraceMapper.FSM_CRK_ReduceType isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 49 | High |
org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap.getData() uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 765 | Medium |
| Method org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap.getData() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 612 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 99 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap(String, String, String, String, HashMap) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 99 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap(String, String, String, String, HashMap, int, int) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 99 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap(String, String, String, String, HashMap, String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 99 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap(HttpServletRequest) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 99 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap.getData() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 757 | Medium |
| integral division result cast to double or float in org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap.addAddlInfo(Heatmap$HeatmapData) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 366 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap.getData() | CORRECTNESS | NP_ALWAYS_NULL | 616 | High |
| Double assignment of field Heatmap$HeatmapData.stats in org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap.getData() | CORRECTNESS | SA_FIELD_DOUBLE_ASSIGNMENT | 751 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap$1.arX | PERFORMANCE | URF_UNREAD_FIELD | 266 | Medium |
| Unread field: org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap$1.arY | PERFORMANCE | URF_UNREAD_FIELD | 265 | Medium |
| Unread field: org.apache.hadoop.chukwa.analysis.salsa.visualization.Heatmap$1.pr | PERFORMANCE | URF_UNREAD_FIELD | 267 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes.getData() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 894 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 416 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes(String, String, String, HashMap) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 416 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes(String, String, String, HashMap, int, int) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 416 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes(String, String, String, HashMap, int, int, String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 416 | Medium |
| new org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes(HttpServletRequest) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 416 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes.addAxisNames() invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 695 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes.setJobName(String) invokes inefficient new String(String) constructor | PERFORMANCE | DM_STRING_CTOR | 538 | Medium |
| integral division result cast to double or float in org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes.addAxisNames() | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 699 | Medium |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes.getData() | CORRECTNESS | NP_ALWAYS_NULL | 878 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes.getData() | CORRECTNESS | NP_ALWAYS_NULL | 882 | High |
org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes$MapReduceSwimlanes
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes$MapReduceSwimlanes be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 85-288 | Medium |
org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes$SwimlanesStatePalette
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes$SwimlanesStatePalette() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 305 | Medium |
| org.apache.hadoop.chukwa.analysis.salsa.visualization.Swimlanes$SwimlanesStatePalette.getStates() may expose internal representation by returning Swimlanes$SwimlanesStatePalette.states | MALICIOUS_CODE | EI_EXPOSE_REP | 320 | Medium |
org.apache.hadoop.chukwa.database.Aggregator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.database.Aggregator.db from instance method org.apache.hadoop.chukwa.database.Aggregator.setWriter(DatabaseWriter) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 85 | High |
org.apache.hadoop.chukwa.database.DataExpiration
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.database.DataExpiration.usage() | CORRECTNESS | NP_ALWAYS_NULL | 100 | High |
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.database.DataExpiration.dropTables(long, long) | STYLE | REC_CATCH_EXCEPTION | 94 | Medium |
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.database.DataExpiration.main(String[]) | STYLE | REC_CATCH_EXCEPTION | 121 | Medium |
| Method org.apache.hadoop.chukwa.database.DataExpiration.dropTables(long, long) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 71 | Medium |
| Method org.apache.hadoop.chukwa.database.DataExpiration.dropTables(long, long) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 53 | Medium |
org.apache.hadoop.chukwa.database.DatabaseConfig
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.database.DatabaseConfig.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 282 | High |
org.apache.hadoop.chukwa.database.Macro
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.database.Macro.db from instance method org.apache.hadoop.chukwa.database.Macro.computeMacro(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 107 | Medium |
| Method org.apache.hadoop.chukwa.database.Macro.toString() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 279 | Medium |
org.apache.hadoop.chukwa.database.MetricsAggregation
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.database.MetricsAggregation.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 85 | High |
| Method org.apache.hadoop.chukwa.database.MetricsAggregation.main(String[]) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 150 | Medium |
org.apache.hadoop.chukwa.database.TableCreator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.database.TableCreator.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 134 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.database.TableCreator.usage() | CORRECTNESS | NP_ALWAYS_NULL | 118 | High |
| Method org.apache.hadoop.chukwa.database.TableCreator.createTables(long, long) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 76 | Medium |
| Method org.apache.hadoop.chukwa.database.TableCreator.createTables(long, long) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 59 | Medium |
org.apache.hadoop.chukwa.datacollection.OffsetStatsManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.chukwa.datacollection.OffsetStatsManager.addOffsetDataPoint(Object, long, long) | MT_CORRECTNESS | JLM_JSR166_UTILCONCURRENT_MONITORENTER | 90 | Medium |
| Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.chukwa.datacollection.OffsetStatsManager.clear() | MT_CORRECTNESS | JLM_JSR166_UTILCONCURRENT_MONITORENTER | 188 | Medium |
| Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.chukwa.datacollection.OffsetStatsManager.get(Object) | MT_CORRECTNESS | JLM_JSR166_UTILCONCURRENT_MONITORENTER | 198 | Medium |
| Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.apache.hadoop.chukwa.datacollection.OffsetStatsManager.remove(Object) | MT_CORRECTNESS | JLM_JSR166_UTILCONCURRENT_MONITORENTER | 179 | Medium |
org.apache.hadoop.chukwa.datacollection.OffsetStatsManager$OffsetData
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed and then immediately unboxed in org.apache.hadoop.chukwa.datacollection.OffsetStatsManager$OffsetData.averageRate(OffsetStatsManager$OffsetData) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED | 218 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.FileAdaptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.datacollection.adaptor.FileAdaptor.TIMEOUT_PERIOD from instance method org.apache.hadoop.chukwa.datacollection.adaptor.FileAdaptor.start(long) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 148 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.FileAdaptorTailer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.hadoop.chukwa.datacollection.adaptor.FileAdaptorTailer.conf in new org.apache.hadoop.chukwa.datacollection.adaptor.FileAdaptorTailer() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 50-53 | Medium |
| Unconditional wait in org.apache.hadoop.chukwa.datacollection.adaptor.FileAdaptorTailer.run() | MT_CORRECTNESS | UW_UNCOND_WAIT | 77 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.JMXAdaptor$JMXConnect
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dereference of the result of readLine() without nullcheck in org.apache.hadoop.chukwa.datacollection.adaptor.JMXAdaptor$JMXConnect.run() | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 105 | Medium |
| org.apache.hadoop.chukwa.datacollection.adaptor.JMXAdaptor$JMXConnect.run() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 104 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.OozieAdaptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.datacollection.adaptor.OozieAdaptor.periodicity from instance method org.apache.hadoop.chukwa.datacollection.adaptor.OozieAdaptor.parseArgs(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 61 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.SyslogAdaptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on trimmedBuf in org.apache.hadoop.chukwa.datacollection.adaptor.SyslogAdaptor.send(byte[], DatagramPacket) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 78 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.WriteaheadBuffered
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.WriteaheadBuffered.fSize; locked 75% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 67 | Medium |
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.WriteaheadBuffered.outToDisk; locked 83% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 77 | Medium |
| org.apache.hadoop.chukwa.datacollection.adaptor.WriteaheadBuffered.committed(long) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 107 | Medium |
| org.apache.hadoop.chukwa.datacollection.adaptor.WriteaheadBuffered.committed(long) ignores exceptional return value of java.io.File.renameTo(File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 96 | Medium |
| org.apache.hadoop.chukwa.datacollection.adaptor.WriteaheadBuffered.shutdown(AdaptorShutdownPolicy) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 118 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.FileTailingAdaptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.FileTailingAdaptor.attempts; locked 90% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 48 | Medium |
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.FileTailingAdaptor.reader; locked 72% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 68 | Medium |
| org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.FileTailingAdaptor.GRACEFUL_PERIOD isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 37 | High |
org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.LWFTAdaptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.LWFTAdaptor.fileReadOffset; locked 90% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 88 | Medium |
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.LWFTAdaptor.offsetOfFirstByte; locked 52% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 74 | Medium |
| org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.LWFTAdaptor.MAX_READ_SIZE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 54 | Medium |
| org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.LWFTAdaptor.tailer should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 60 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.LWFTAdaptor.MAX_READ_SIZE from instance method org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.LWFTAdaptor.parseArgs(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 110 | High |
org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.RCheckFTAdaptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.RCheckFTAdaptor.cur; locked 76% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 119 | Medium |
| Inconsistent synchronization of org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.RCheckFTAdaptor.prevFileLastModDate; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 89 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.RCheckFTAdaptor$FPair
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.RCheckFTAdaptor$FPair defines compareTo(RCheckFTAdaptor$FPair) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 49-55 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.jms.JMSAdaptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.datacollection.adaptor.jms.JMSAdaptor.parseArgs(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 176 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.jms.JMSMessagePropertyTransformer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.datacollection.adaptor.jms.JMSMessagePropertyTransformer.parseArgs(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 78 | Medium |
org.apache.hadoop.chukwa.datacollection.adaptor.sigar.SigarRunner
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.datacollection.adaptor.sigar.SigarRunner.run() | STYLE | REC_CATCH_EXCEPTION | 212 | Medium |
org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.shutdown(boolean) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 786 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 275 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 284 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 313 | Medium |
| new org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent(Configuration) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 126 | Medium |
| org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.writeCheckpoint() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 603 | Medium |
| new org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent(Configuration) invokes org.apache.hadoop.chukwa.datacollection.agent.AgentControlSocketListener.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 167 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.agent from instance method new org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 100 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.conf from instance method new org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 101 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent.tags from instance method new org.apache.hadoop.chukwa.datacollection.agent.ChukwaAgent(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 128 | Medium |
org.apache.hadoop.chukwa.datacollection.agent.WaitingQueue
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.agent.WaitingQueue.collect(List, int) | CORRECTNESS | NP_ALWAYS_NULL | 54 | High |
org.apache.hadoop.chukwa.datacollection.collector.CollectorStub
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.collector.CollectorStub.jettyServer should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 43 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.collector.CollectorStub.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 50 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.collector.CollectorStub.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 100 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.collector.CollectorStub.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 140 | High |
org.apache.hadoop.chukwa.datacollection.collector.servlet.CommitCheckServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.collector.servlet.CommitCheckServlet.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 41 | High |
| org.apache.hadoop.chukwa.datacollection.collector.servlet.CommitCheckServlet.doGet(HttpServletRequest, HttpServletResponse) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 81 | Medium |
| Class org.apache.hadoop.chukwa.datacollection.collector.servlet.CommitCheckServlet defines non-transient non-serializable instance field commitCheck | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.hadoop.chukwa.datacollection.collector.servlet.CommitCheckServlet defines non-transient non-serializable instance field conf | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
org.apache.hadoop.chukwa.datacollection.collector.servlet.CommitCheckServlet$CommitCheckThread$PurgeTask
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.collector.servlet.CommitCheckServlet$CommitCheckThread$PurgeTask defines compareTo(CommitCheckServlet$CommitCheckThread$PurgeTask) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 121-126 | Medium |
org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet.getSID(Chunk) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 109 | Medium |
| org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 70 | High |
| org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet.doGet(HttpServletRequest, HttpServletResponse) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 149 | Medium |
| Class org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet defines non-transient non-serializable instance field conf | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.writer.ExtractorWriter.recipient from instance method new org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 74 | High |
| Write to static field org.apache.hadoop.chukwa.datacollection.writer.ExtractorWriter.recipient from instance method new org.apache.hadoop.chukwa.datacollection.collector.servlet.LogDisplayServlet(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 79 | High |
org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to diagnosticPage in org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.accept(HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 156 | High |
| org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.doGet(HttpServletRequest, HttpServletResponse) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 256 | Medium |
| Class org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector defines non-transient non-serializable instance field conf | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| Class org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector defines non-transient non-serializable instance field log | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
| org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter stored into non-transient field ServletCollector.writer | BAD_PRACTICE | SE_BAD_FIELD_STORE | 138 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.CODEC_NAME from instance method org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.init(ServletConfig) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 123 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.COMPRESS from instance method org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.init(ServletConfig) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 121 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.codec from instance method org.apache.hadoop.chukwa.datacollection.collector.servlet.ServletCollector.init(ServletConfig) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 127 | Medium |
org.apache.hadoop.chukwa.datacollection.connector.ChunkCatcherConnector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.connector.ChunkCatcherConnector.reloadConfiguration() | CORRECTNESS | NP_ALWAYS_NULL | 77 | High |
org.apache.hadoop.chukwa.datacollection.connector.ChunkCatcherConnector$Interruptor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.hadoop.chukwa.datacollection.connector.ChunkCatcherConnector$Interruptor be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 33-41 | Medium |
org.apache.hadoop.chukwa.datacollection.connector.PipelineConnector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.datacollection.connector.PipelineConnector.agent from instance method org.apache.hadoop.chukwa.datacollection.connector.PipelineConnector.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 82 | Medium |
org.apache.hadoop.chukwa.datacollection.connector.http.HttpConnector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.connector.http.HttpConnector.run() | CORRECTNESS | NP_ALWAYS_NULL | 165 | High |
org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.addByName(String, String, String, String, long, long, long) | CORRECTNESS | NP_ALWAYS_NULL | 264 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.addByName(String, String, String, String, long, long, long) | CORRECTNESS | NP_ALWAYS_NULL | 281 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.doAddFile(ChukwaAgentController, String, String) | CORRECTNESS | NP_ALWAYS_NULL | 566 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 531 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.removeAll() | CORRECTNESS | NP_ALWAYS_NULL | 320 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.syncWithAgent() | CORRECTNESS | NP_ALWAYS_NULL | 216 | High |
| Load of known null value in org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.doAddFile(ChukwaAgentController, String, String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 566 | Medium |
| Method org.apache.hadoop.chukwa.datacollection.controller.ChukwaAgentController.list() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 375 | Medium |
org.apache.hadoop.chukwa.datacollection.sender.AsyncAckSender
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.sender.AsyncAckSender.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 47 | High |
| new org.apache.hadoop.chukwa.datacollection.sender.AsyncAckSender(Configuration, ChukwaAgent) invokes org.apache.hadoop.chukwa.datacollection.agent.AdaptorResetThread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 219 | Medium |
org.apache.hadoop.chukwa.datacollection.sender.AsyncAckSender$DelayedCommit
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.sender.AsyncAckSender$DelayedCommit defines compareTo(AsyncAckSender$DelayedCommit) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 74-84 | Medium |
| Self comparison of AsyncAckSender$DelayedCommit.fname with itself in org.apache.hadoop.chukwa.datacollection.sender.AsyncAckSender$DelayedCommit.compareTo(AsyncAckSender$DelayedCommit) | CORRECTNESS | SA_FIELD_SELF_COMPARISON | 77 | Medium |
org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender.doRequest(HttpMethodBase, String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 357 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender.COMPRESS from instance method new org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 173 | High |
| Write to static field org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender.CODEC_NAME from instance method new org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 175 | Medium |
| Write to static field org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender.codec from instance method new org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 179 | Medium |
org.apache.hadoop.chukwa.datacollection.sender.RetryListOfCollectors
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in new org.apache.hadoop.chukwa.datacollection.sender.RetryListOfCollectors(File, Configuration) | CORRECTNESS | NP_ALWAYS_NULL | 59 | Medium |
| Null pointer dereference of System.err in new org.apache.hadoop.chukwa.datacollection.sender.RetryListOfCollectors(File, Configuration) | CORRECTNESS | NP_ALWAYS_NULL | 65 | Medium |
| Unread field: org.apache.hadoop.chukwa.datacollection.sender.RetryListOfCollectors.conf | PERFORMANCE | URF_UNREAD_FIELD | 107 | Medium |
org.apache.hadoop.chukwa.datacollection.test.ConsoleOutConnector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.test.ConsoleOutConnector.reloadConfiguration() | CORRECTNESS | NP_ALWAYS_NULL | 87 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.test.ConsoleOutConnector.run() | CORRECTNESS | NP_ALWAYS_NULL | 49 | High |
org.apache.hadoop.chukwa.datacollection.test.FilePerPostWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field FilePerPostWriter.conf masks field in superclass org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter | CORRECTNESS | MF_CLASS_MASKS_FIELD | 44-133 | High |
| Field FilePerPostWriter.currentFileName masks field in superclass org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter | CORRECTNESS | MF_CLASS_MASKS_FIELD | 44-133 | High |
| Field FilePerPostWriter.currentPath masks field in superclass org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter | CORRECTNESS | MF_CLASS_MASKS_FIELD | 44-133 | High |
| Field FilePerPostWriter.fs masks field in superclass org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter | CORRECTNESS | MF_CLASS_MASKS_FIELD | 44-133 | High |
| Field FilePerPostWriter.outputDir masks field in superclass org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter | CORRECTNESS | MF_CLASS_MASKS_FIELD | 44-133 | Medium |
| Nullcheck of chunk at line 81 of value previously dereferenced in org.apache.hadoop.chukwa.datacollection.test.FilePerPostWriter.add(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 81 | Medium |
org.apache.hadoop.chukwa.datacollection.test.FileTailerStressTest
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.test.FileTailerStressTest.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 104 | High |
| org.apache.hadoop.chukwa.datacollection.test.FileTailerStressTest.main(String[]) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 105 | Medium |
| org.apache.hadoop.chukwa.datacollection.test.FileTailerStressTest.main(String[]) ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 94 | Medium |
org.apache.hadoop.chukwa.datacollection.test.SinkFileValidator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.test.SinkFileValidator.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 37 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.test.SinkFileValidator.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 53 | High |
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.datacollection.test.SinkFileValidator.main(String[]) | STYLE | REC_CATCH_EXCEPTION | 75 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.ConsoleWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.writer.ConsoleWriter.add(Chunk) | CORRECTNESS | NP_ALWAYS_NULL | 77 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.writer.ConsoleWriter.init(Configuration) | CORRECTNESS | NP_ALWAYS_NULL | 67 | High |
org.apache.hadoop.chukwa.datacollection.writer.ConsoleWriter$StatReportingTask
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.datacollection.writer.ConsoleWriter$StatReportingTask.run() | CORRECTNESS | NP_ALWAYS_NULL | 48 | High |
org.apache.hadoop.chukwa.datacollection.writer.ExtractorWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.writer.ExtractorWriter.recipient isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | Not available | Medium |
org.apache.hadoop.chukwa.datacollection.writer.InMemoryWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Naked notify in org.apache.hadoop.chukwa.datacollection.writer.InMemoryWriter.add(Chunk) | MT_CORRECTNESS | NN_NAKED_NOTIFY | 48 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.PipelineStageWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.datacollection.writer.PipelineStageWriter.init(Configuration) | STYLE | REC_CATCH_EXCEPTION | 114 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter.ENABLE_ROTATION_ON_CLOSE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 51 | High |
| org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter.localHostAddr isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 64 | High |
| Null pointer dereference of SeqFileWriter.fs in org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter.init(Configuration) | CORRECTNESS | NP_ALWAYS_NULL | 139 | Medium |
| Nullcheck of chunk at line 340 of value previously dereferenced in org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter.add(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 340 | Medium |
| Nullcheck of chunks at line 330 of value previously dereferenced in org.apache.hadoop.chukwa.datacollection.writer.SeqFileWriter.add(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 324 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.SocketTeeWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field SocketTeeWriter.next masks field in superclass org.apache.hadoop.chukwa.datacollection.writer.PipelineableWriter | CORRECTNESS | MF_CLASS_MASKS_FIELD | 58-293 | High |
org.apache.hadoop.chukwa.datacollection.writer.SocketTeeWriter$Tee
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dereference of the result of readLine() without nullcheck in org.apache.hadoop.chukwa.datacollection.writer.SocketTeeWriter$Tee.setup() | STYLE | NP_DEREFERENCE_OF_READLINE_VALUE | 176 | Medium |
| org.apache.hadoop.chukwa.datacollection.writer.SocketTeeWriter$Tee.handle(Chunk) ignores exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 243 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.hbase.OutputCollector
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.hadoop.chukwa.datacollection.writer.hbase.OutputCollector shadows the simple name of implemented interface org.apache.hadoop.mapred.OutputCollector | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_INTERFACE | 29-71 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.hbase.Reporter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.hadoop.chukwa.datacollection.writer.hbase.Reporter shadows the simple name of implemented interface org.apache.hadoop.mapred.Reporter | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_INTERFACE | 24-77 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.localfs.LocalToRemoteHdfsMover
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of LocalToRemoteHdfsMover.remoteFs in org.apache.hadoop.chukwa.datacollection.writer.localfs.LocalToRemoteHdfsMover.init() | CORRECTNESS | NP_ALWAYS_NULL | 89 | Medium |
| new org.apache.hadoop.chukwa.datacollection.writer.localfs.LocalToRemoteHdfsMover(BlockingQueue, Configuration) invokes org.apache.hadoop.chukwa.datacollection.writer.localfs.LocalToRemoteHdfsMover.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 66 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.localfs.LocalWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of chunk at line 244 of value previously dereferenced in org.apache.hadoop.chukwa.datacollection.writer.localfs.LocalWriter.add(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 244 | Medium |
org.apache.hadoop.chukwa.datacollection.writer.solr.SolrWriter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.datacollection.writer.solr.SolrWriter.server from instance method org.apache.hadoop.chukwa.datacollection.writer.solr.SolrWriter.init(Configuration) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 55 | High |
org.apache.hadoop.chukwa.dataloader.DataLoaderFactory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.dataloader.DataLoaderFactory.load(ChukwaConfiguration, FileSystem, FileStatus[]) may expose internal representation by storing an externally mutable object into DataLoaderFactory.source | MALICIOUS_CODE | EI_EXPOSE_REP2 | 40 | Medium |
| Write to static field org.apache.hadoop.chukwa.dataloader.DataLoaderFactory.conf from instance method org.apache.hadoop.chukwa.dataloader.DataLoaderFactory.load(ChukwaConfiguration, FileSystem, FileStatus[]) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 41 | High |
| Write to static field org.apache.hadoop.chukwa.dataloader.DataLoaderFactory.fs from instance method org.apache.hadoop.chukwa.dataloader.DataLoaderFactory.load(ChukwaConfiguration, FileSystem, FileStatus[]) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 42 | High |
org.apache.hadoop.chukwa.dataloader.FSMDataLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.hadoop.chukwa.dataloader.FSMDataLoader.completion in org.apache.hadoop.chukwa.dataloader.FSMDataLoader.load(ChukwaConfiguration, FileSystem, FileStatus[]) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 67-68 | Medium |
| Incorrect lazy initialization of static field org.apache.hadoop.chukwa.dataloader.FSMDataLoader.executor in org.apache.hadoop.chukwa.dataloader.FSMDataLoader.load(ChukwaConfiguration, FileSystem, FileStatus[]) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 59-65 | Medium |
org.apache.hadoop.chukwa.dataloader.MetricDataLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of reader in org.apache.hadoop.chukwa.dataloader.MetricDataLoader.run() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 198 | Medium |
| Method org.apache.hadoop.chukwa.dataloader.MetricDataLoader.run() passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 490 | High |
| Write to static field org.apache.hadoop.chukwa.dataloader.MetricDataLoader.conf from instance method new org.apache.hadoop.chukwa.dataloader.MetricDataLoader(ChukwaConfiguration, FileSystem, String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 72 | High |
| Write to static field org.apache.hadoop.chukwa.dataloader.MetricDataLoader.fs from instance method new org.apache.hadoop.chukwa.dataloader.MetricDataLoader(ChukwaConfiguration, FileSystem, String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 73 | High |
| Method org.apache.hadoop.chukwa.dataloader.MetricDataLoader.initEnv(String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 112 | Medium |
| Method org.apache.hadoop.chukwa.dataloader.MetricDataLoader.run() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 342 | Medium |
org.apache.hadoop.chukwa.dataloader.MetricDataLoaderPool
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.apache.hadoop.chukwa.dataloader.MetricDataLoaderPool.completion in org.apache.hadoop.chukwa.dataloader.MetricDataLoaderPool.load(ChukwaConfiguration, FileSystem, FileStatus[]) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 56-57 | Medium |
| Incorrect lazy initialization of static field org.apache.hadoop.chukwa.dataloader.MetricDataLoaderPool.executor in org.apache.hadoop.chukwa.dataloader.MetricDataLoaderPool.load(ChukwaConfiguration, FileSystem, FileStatus[]) | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 48-54 | Medium |
org.apache.hadoop.chukwa.dataloader.SocketDataLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.hadoop.chukwa.dataloader.SocketDataLoader.dis; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 175 | Medium |
| Inconsistent synchronization of org.apache.hadoop.chukwa.dataloader.SocketDataLoader.dos; locked 66% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 142 | Medium |
| Inconsistent synchronization of org.apache.hadoop.chukwa.dataloader.SocketDataLoader.s; locked 57% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 139 | Medium |
org.apache.hadoop.chukwa.datastore.ChukwaHBaseStore
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.datastore.ChukwaHBaseStore.getHeatmap(String, String, String, long, long, double, double, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 295 | Medium |
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.datastore.ChukwaHBaseStore.getSeries(String, String, String, String, long, long, boolean) | STYLE | REC_CATCH_EXCEPTION | 103 | Medium |
org.apache.hadoop.chukwa.datastore.UserStore
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.datastore.UserStore.config from instance method new org.apache.hadoop.chukwa.datastore.UserStore() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 50 | Medium |
org.apache.hadoop.chukwa.datastore.ViewStore
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.datastore.ViewStore.config from instance method new org.apache.hadoop.chukwa.datastore.ViewStore() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 55 | Medium |
org.apache.hadoop.chukwa.datastore.WidgetStore
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.datastore.WidgetStore.config from instance method new org.apache.hadoop.chukwa.datastore.WidgetStore() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 51 | Medium |
org.apache.hadoop.chukwa.datatrigger.HttpTriggerAction
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on nvp in org.apache.hadoop.chukwa.datatrigger.HttpTriggerAction.getHeaders(Configuration, TriggerEvent, int) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 218 | High |
| Method org.apache.hadoop.chukwa.datatrigger.HttpTriggerAction.makeHttpRequest(URL, String, Map, String, int, int) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 134 | Medium |
org.apache.hadoop.chukwa.extraction.archive.ChukwaArchiveBuilder
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.archive.ChukwaArchiveBuilder.printUsage() | CORRECTNESS | NP_ALWAYS_NULL | 79 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.archive.ChukwaArchiveBuilder.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 89 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.archive.ChukwaArchiveBuilder.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 127 | High |
org.apache.hadoop.chukwa.extraction.archive.SinkArchiver
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.archive.SinkArchiver.promoteAndMerge(FileSystem, Path, Path) | CORRECTNESS | NP_ALWAYS_NULL | 160 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.archive.SinkArchiver.promoteAndMerge(FileSystem, Path, Path) | CORRECTNESS | NP_ALWAYS_NULL | 179 | High |
org.apache.hadoop.chukwa.extraction.demux.DailyChukwaRecordRolling
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.extraction.demux.DailyChukwaRecordRolling.usage() | CORRECTNESS | NP_ALWAYS_NULL | 65 | High |
| org.apache.hadoop.chukwa.extraction.demux.DailyChukwaRecordRolling.buildDailyFiles(String, String, String, int) explicitly invokes run on a thread (did you mean to start it instead?) | MT_CORRECTNESS | RU_INVOKE_RUN | 169 | Medium |
org.apache.hadoop.chukwa.extraction.demux.Demux
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.extraction.demux.Demux.jobConf isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 65 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.Demux.printUsage() | CORRECTNESS | NP_ALWAYS_NULL | 175 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.Demux.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 226 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.Demux.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 229 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.Demux.run(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 236 | High |
org.apache.hadoop.chukwa.extraction.demux.Demux$MapClass
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on org.apache.hadoop.chukwa.ChunkImpl.getData() in org.apache.hadoop.chukwa.extraction.demux.Demux$MapClass.map(ChukwaArchiveKey, ChunkImpl, OutputCollector, Reporter) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 85 | Medium |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.Demux.jobConf from instance method org.apache.hadoop.chukwa.extraction.demux.Demux$MapClass.configure(JobConf) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 73 | Medium |
org.apache.hadoop.chukwa.extraction.demux.Demux$ReduceClass
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.Demux$ReduceClass.reduce(ChukwaRecordKey, Iterator, OutputCollector, Reporter) | CORRECTNESS | NP_ALWAYS_NULL | 158 | High |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.Demux.jobConf from instance method org.apache.hadoop.chukwa.extraction.demux.Demux$ReduceClass.configure(JobConf) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 130 | Medium |
org.apache.hadoop.chukwa.extraction.demux.DemuxManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Result of integer multiplication cast to long in org.apache.hadoop.chukwa.extraction.demux.DemuxManager.start() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 214 | Medium |
| Nullcheck of reportingHost at line 149 of value previously dereferenced in org.apache.hadoop.chukwa.extraction.demux.DemuxManager.start() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 149 | Medium |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.DemuxManager.firstErrorTime from instance method org.apache.hadoop.chukwa.extraction.demux.DemuxManager.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 210 | Medium |
org.apache.hadoop.chukwa.extraction.demux.DoMerge
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.DoMerge.run() | CORRECTNESS | NP_ALWAYS_NULL | 196 | High |
org.apache.hadoop.chukwa.extraction.demux.HourlyChukwaRecordRolling
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.extraction.demux.HourlyChukwaRecordRolling.usage() | CORRECTNESS | NP_ALWAYS_NULL | 64 | High |
| org.apache.hadoop.chukwa.extraction.demux.HourlyChukwaRecordRolling.buildHourlyFiles(String, String, String, int, int) explicitly invokes run on a thread (did you mean to start it instead?) | MT_CORRECTNESS | RU_INVOKE_RUN | 125 | Medium |
org.apache.hadoop.chukwa.extraction.demux.MoveOrMergeRecordFile
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.MoveOrMergeRecordFile.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 173 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.MoveOrMergeRecordFile.moveOrMergeOneCluster(Path, String) | CORRECTNESS | NP_ALWAYS_NULL | 75 | High |
org.apache.hadoop.chukwa.extraction.demux.PostProcessorManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Result of integer multiplication cast to long in org.apache.hadoop.chukwa.extraction.demux.PostProcessorManager.start() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 184 | Medium |
| org.apache.hadoop.chukwa.extraction.demux.PostProcessorManager.errorCount should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 47 | Medium |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.PostProcessorManager.dataSources from instance method org.apache.hadoop.chukwa.extraction.demux.PostProcessorManager.start() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 119 | Medium |
org.apache.hadoop.chukwa.extraction.demux.RecordMerger
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.hadoop.chukwa.extraction.demux.RecordMerger(ChukwaConfiguration, FileSystem, Tool, String[], boolean) may expose internal representation by storing an externally mutable object into RecordMerger.mergeArgs | MALICIOUS_CODE | EI_EXPOSE_REP2 | 46 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.demux.RecordMerger.run() | CORRECTNESS | NP_ALWAYS_NULL | 52 | High |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.ClientTraceProcessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.extraction.demux.processor.mapper.ClientTraceProcessor.parse(String, OutputCollector, Reporter) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 133 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.HadoopMetricsProcessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.extraction.demux.processor.mapper.HadoopMetricsProcessor.parse(String, OutputCollector, Reporter) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 111 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Iostat
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Iostat.parse(String, OutputCollector, Reporter) | STYLE | REC_CATCH_EXCEPTION | 126 | Medium |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Iostat.p from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Iostat() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 48 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobConfProcessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobConfProcessor.parse(String, OutputCollector, Reporter) | STYLE | REC_CATCH_EXCEPTION | 143 | Medium |
| org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobConfProcessor.parse(String, OutputCollector, Reporter) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 142 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobLogHistoryProcessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobLogHistoryProcessor.internalRegex from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobLogHistoryProcessor() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 47 | High |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobLogHistoryProcessor.ip from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobLogHistoryProcessor() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 48 | Medium |
| Method org.apache.hadoop.chukwa.extraction.demux.processor.mapper.JobLogHistoryProcessor.parse(String, OutputCollector, Reporter) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 337 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Log4jJobHistoryProcessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Log4jJobHistoryProcessor.internalRegex from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Log4jJobHistoryProcessor() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 43 | High |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Log4jJobHistoryProcessor.ip from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Log4jJobHistoryProcessor() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 44 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.LogEntry
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.extraction.demux.processor.mapper.LogEntry.getDate() may expose internal representation by returning LogEntry.date | MALICIOUS_CODE | EI_EXPOSE_REP | 46 | Medium |
| org.apache.hadoop.chukwa.extraction.demux.processor.mapper.LogEntry.setDate(Date) may expose internal representation by storing an externally mutable object into LogEntry.date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 50 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Sar
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Sar.parse(String, OutputCollector, Reporter) | STYLE | REC_CATCH_EXCEPTION | 152 | Medium |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Sar.p from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Sar() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 49 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.SysLog
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to body in org.apache.hadoop.chukwa.extraction.demux.processor.mapper.SysLog.parse(String, OutputCollector, Reporter) | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.SystemMetrics
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.extraction.demux.processor.mapper.SystemMetrics.parse(String, OutputCollector, Reporter) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 79 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Top
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Top.parse(String, OutputCollector, Reporter) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 81 | Medium |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Top.p from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Top() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 55 | Medium |
| Method org.apache.hadoop.chukwa.extraction.demux.processor.mapper.Top.parseSummary(ChukwaRecord, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 164 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.mapper.YWatch
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.YWatch.regex from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.YWatch() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 46 | High |
| Write to static field org.apache.hadoop.chukwa.extraction.demux.processor.mapper.YWatch.p from instance method new org.apache.hadoop.chukwa.extraction.demux.processor.mapper.YWatch() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 47 | Medium |
org.apache.hadoop.chukwa.extraction.demux.processor.reducer.MRJobReduceProcessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.extraction.demux.processor.reducer.MRJobReduceProcessor.process(ChukwaRecordKey, Iterator, OutputCollector, Reporter) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 79 | Medium |
org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 239-243 | High |
org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT$Comparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordJT$Comparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 263-372 | Medium |
org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey.clone() does not call super.clone() | BAD_PRACTICE | CN_IDIOM_NO_SUPER_CALL | 181-184 | Medium |
org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to l2 in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 259 | High |
| Dead store to l in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.slurpRaw(byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 220 | High |
| Dead store to l1 in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 268 | Medium |
| Dead store to s2 in org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator.compareRaw(byte[], int, int, byte[], int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 266 | Medium |
| org.apache.hadoop.chukwa.extraction.engine.ChukwaRecordKey$Comparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 204-278 | Medium |
org.apache.hadoop.chukwa.extraction.engine.datasource.DsDirectory
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.DsDirectory.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 86 | High |
| Write to static field org.apache.hadoop.chukwa.extraction.engine.datasource.DsDirectory.conf from instance method new org.apache.hadoop.chukwa.extraction.engine.datasource.DsDirectory() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 44 | Medium |
org.apache.hadoop.chukwa.extraction.engine.datasource.database.DatabaseDS
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.extraction.engine.datasource.database.DatabaseDS.search(SearchResult, String, String, long, long, String, Token) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 64 | Medium |
| Method org.apache.hadoop.chukwa.extraction.engine.datasource.database.DatabaseDS.search(SearchResult, String, String, long, long, String, Token) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 97 | Medium |
| Method org.apache.hadoop.chukwa.extraction.engine.datasource.database.DatabaseDS.search(SearchResult, String, String, long, long, String, Token) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 84 | High |
org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaDSInternalResult
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaDSInternalResult.key | PERFORMANCE | URF_UNREAD_FIELD | 36 | Medium |
org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaFileParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaFileParser.readData(String, String, int, long, long, long, String, String, FileSystem) | CORRECTNESS | NP_ALWAYS_NULL | 47 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaFileParser.readData(String, String, int, long, long, long, String, String, FileSystem) | CORRECTNESS | NP_ALWAYS_NULL | 50 | High |
| Possible null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaFileParser.readData(String, String, int, long, long, long, String, String, FileSystem) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 137 | Medium |
| Exception is caught when Exception is not thrown in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaFileParser.readData(String, String, int, long, long, long, String, String, FileSystem) | STYLE | REC_CATCH_EXCEPTION | 134 | Medium |
org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaRecordDataSource
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Comparison of String objects using == or != in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaRecordDataSource.search(SearchResult, String, String, long, long, String, Token) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 153 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaRecordDataSource.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 465 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaRecordDataSource.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 468 | High |
| Can't close r since it is always null in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaRecordDataSource.readData(ChukwaDSInternalResult, Token, String, int, long, long, String) | CORRECTNESS | NP_CLOSING_NULL | 356 | High |
org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaSequenceFileParser
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaSequenceFileParser.readData(String, String, int, long, long, long, String, String, FileSystem, Configuration) | CORRECTNESS | NP_ALWAYS_NULL | 53 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaSequenceFileParser.readData(String, String, int, long, long, long, String, String, FileSystem, Configuration) | CORRECTNESS | NP_ALWAYS_NULL | 56 | High |
| Possible null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.ChukwaSequenceFileParser.readData(String, String, int, long, long, long, String, String, FileSystem, Configuration) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 124 | Medium |
org.apache.hadoop.chukwa.extraction.engine.datasource.record.RecordDS
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.extraction.engine.datasource.record.RecordDS.search(SearchResult, String, String, long, long, String, Token) | CORRECTNESS | NP_ALWAYS_NULL | 62 | High |
org.apache.hadoop.chukwa.hicc.Chart
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.datasetCounter | PERFORMANCE | URF_UNREAD_FIELD | 55 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.graphType | PERFORMANCE | URF_UNREAD_FIELD | 74 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.rightList | PERFORMANCE | URF_UNREAD_FIELD | 84 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.seriesCounter | PERFORMANCE | URF_UNREAD_FIELD | 58 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.xLabelOn | PERFORMANCE | URF_UNREAD_FIELD | 75 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.yLabel | PERFORMANCE | URF_UNREAD_FIELD | 53 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.yLabelOn | PERFORMANCE | URF_UNREAD_FIELD | 76 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.yRightLabel | PERFORMANCE | URF_UNREAD_FIELD | 54 | Medium |
| Unread field: org.apache.hadoop.chukwa.hicc.Chart.yRightLabelOn | PERFORMANCE | URF_UNREAD_FIELD | 160 | Medium |
org.apache.hadoop.chukwa.hicc.HiccWebServer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Can't close System.out since it is always null in org.apache.hadoop.chukwa.hicc.HiccWebServer.main(String[]) | CORRECTNESS | NP_CLOSING_NULL | 225 | High |
org.apache.hadoop.chukwa.hicc.Workspace
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.hicc.Workspace.addToHash(JSONObject, String[], JSONObject) | CORRECTNESS | NP_ALWAYS_NULL | 342 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.hicc.Workspace.convertObjectsToViewList(JSONObject[]) | CORRECTNESS | NP_ALWAYS_NULL | 262 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.hicc.Workspace.convertObjectsToViewList(JSONObject[]) | CORRECTNESS | NP_ALWAYS_NULL | 273 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.hicc.Workspace.convertObjectsToWidgetList(JSONObject[]) | CORRECTNESS | NP_ALWAYS_NULL | 314 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.hicc.Workspace.convertObjectsToWidgetList(JSONObject[]) | CORRECTNESS | NP_ALWAYS_NULL | 322 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.hicc.Workspace.convertObjectsToWidgetList(JSONObject[]) | CORRECTNESS | NP_ALWAYS_NULL | 328 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.hicc.Workspace.setContents(String, String) | CORRECTNESS | NP_ALWAYS_NULL | 114 | High |
org.apache.hadoop.chukwa.inputtools.jplugin.JPluginAgent
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.inputtools.jplugin.JPluginAgent.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 80 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.inputtools.jplugin.JPluginAgent.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 92 | High |
org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible doublecheck on org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender.hasBeenActivated in org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender.checkEntryConditions() | MT_CORRECTNESS | DC_DOUBLECHECK | 487-489 | Medium |
| Inconsistent synchronization of org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender.cleanUpRegex; locked 60% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 413 | Medium |
| Null pointer dereference of System.out in new org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender(Layout, String, String) | CORRECTNESS | NP_ALWAYS_NULL | 247 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender.subAppend(LoggingEvent) | CORRECTNESS | NP_ALWAYS_NULL | 624 | High |
| Load of known null value in org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender.subAppend(LoggingEvent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 579 | Medium |
| org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender.cleanUp() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 450 | Medium |
| org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender.rollOver() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 384 | Medium |
org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender$LogFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.hadoop.chukwa.inputtools.log4j.ChukwaDailyRollingFileAppender$LogFilter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 460-478 | Medium |
org.apache.hadoop.chukwa.inputtools.log4j.RollingCalendar
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.inputtools.log4j.RollingCalendar doesn't override java.util.GregorianCalendar.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 669-738 | Medium |
org.apache.hadoop.chukwa.inputtools.log4j.TaskLogAppender
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.apache.hadoop.chukwa.inputtools.log4j.TaskLogAppender shadows the simple name of the superclass org.apache.hadoop.mapred.TaskLogAppender | BAD_PRACTICE | NM_SAME_SIMPLE_NAME_AS_SUPERCLASS | 27-79 | High |
| Load of known null value in org.apache.hadoop.chukwa.inputtools.log4j.TaskLogAppender.subAppend(LoggingEvent) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 72 | Medium |
org.apache.hadoop.chukwa.inputtools.mdl.DataConfig
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.hadoop.chukwa.inputtools.mdl.DataConfig.config in new org.apache.hadoop.chukwa.inputtools.mdl.DataConfig() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 51-54 | Medium |
| Write to static field org.apache.hadoop.chukwa.inputtools.mdl.DataConfig.config from instance method new org.apache.hadoop.chukwa.inputtools.mdl.DataConfig(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 39 | Medium |
org.apache.hadoop.chukwa.inputtools.mdl.LoaderServer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.inputtools.mdl.LoaderServer.init() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 64 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.inputtools.mdl.LoaderServer.init() | CORRECTNESS | NP_ALWAYS_NULL | 61 | High |
| Write to static field org.apache.hadoop.chukwa.inputtools.mdl.LoaderServer.lock from instance method org.apache.hadoop.chukwa.inputtools.mdl.LoaderServer.init() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 54 | Medium |
| Write to static field org.apache.hadoop.chukwa.inputtools.mdl.LoaderServer.pidFileOutput from instance method org.apache.hadoop.chukwa.inputtools.mdl.LoaderServer.init() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 50 | Medium |
org.apache.hadoop.chukwa.inputtools.mdl.TorqueDataLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.inputtools.mdl.TorqueDataLoader.run() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 52 | Medium |
org.apache.hadoop.chukwa.inputtools.mdl.TorqueInfoProcessor
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentTime in org.apache.hadoop.chukwa.inputtools.mdl.TorqueInfoProcessor.process_data() | STYLE | DLS_DEAD_LOCAL_STORE | 405 | Medium |
| org.apache.hadoop.chukwa.inputtools.mdl.TorqueInfoProcessor.getHodJobInfo() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 81 | Medium |
| org.apache.hadoop.chukwa.inputtools.mdl.TorqueInfoProcessor.loadTraceJobData(String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 300 | Medium |
org.apache.hadoop.chukwa.inputtools.mdl.TorqueTimerTask
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.hadoop.chukwa.inputtools.mdl.TorqueTimerTask.timeoutInterval isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 31 | Medium |
org.apache.hadoop.chukwa.inputtools.plugin.metrics.Exec
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.inputtools.plugin.metrics.Exec.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 73 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.inputtools.plugin.metrics.Exec.run() | CORRECTNESS | NP_ALWAYS_NULL | 49 | High |
org.apache.hadoop.chukwa.inputtools.plugin.nodeactivity.NodeActivityPlugin
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.inputtools.plugin.nodeactivity.NodeActivityPlugin.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 98 | High |
org.apache.hadoop.chukwa.inputtools.plugin.pbsnode.PbsNodePlugin
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.inputtools.plugin.pbsnode.PbsNodePlugin.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 46 | High |
org.apache.hadoop.chukwa.rest.bean.WidgetBean
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals() comparing different types in new org.apache.hadoop.chukwa.rest.bean.WidgetBean(JSONObject) | CORRECTNESS | EC_UNRELATED_TYPES | 61 | High |
org.apache.hadoop.chukwa.tools.backfilling.BackfillingLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.tools.backfilling.BackfillingLoader.process() | CORRECTNESS | NP_ALWAYS_NULL | 79 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.tools.backfilling.BackfillingLoader.usage() | CORRECTNESS | NP_ALWAYS_NULL | 84 | High |
org.apache.hadoop.chukwa.util.ConstRateValidator$ReduceClass
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.ConstRateValidator$ReduceClass.reduce(ConstRateValidator$ByteRange, Iterable, Reducer$Context) | CORRECTNESS | NP_ALWAYS_NULL | 231 | High |
org.apache.hadoop.chukwa.util.ConstRateValidator$ValidatorSM
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.ConstRateValidator$ValidatorSM.advanceSM(ConstRateValidator$ByteRange) | CORRECTNESS | NP_ALWAYS_NULL | 172 | High |
org.apache.hadoop.chukwa.util.CopySequenceFile
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.CopySequenceFile.createValidSequenceFile(Configuration, String, String, FileSystem) | CORRECTNESS | NP_ALWAYS_NULL | 75 | High |
org.apache.hadoop.chukwa.util.CreateRecordFile
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.CreateRecordFile.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 153 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.CreateRecordFile.usage() | CORRECTNESS | NP_ALWAYS_NULL | 168 | High |
org.apache.hadoop.chukwa.util.DumpArchive
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.util.DumpArchive.dumpFile(Path, Configuration, FileSystem) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 112 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.DumpArchive.dumpFile(Path, Configuration, FileSystem) | CORRECTNESS | NP_ALWAYS_NULL | 115 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.util.DumpArchive.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 83 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.DumpArchive.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 57 | High |
org.apache.hadoop.chukwa.util.DumpChunks
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.util.DumpChunks.displayResults(PrintStream) | CORRECTNESS | NP_ALWAYS_NULL | 152 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.util.DumpChunks.displayResults(PrintStream) | CORRECTNESS | NP_ALWAYS_NULL | 156 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.util.DumpChunks.dump(String[], Configuration, PrintStream) | CORRECTNESS | NP_ALWAYS_NULL | 92 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.util.DumpChunks.dump(String[], Configuration, PrintStream) | CORRECTNESS | NP_ALWAYS_NULL | 97 | High |
| Null pointer dereference of System.err in org.apache.hadoop.chukwa.util.DumpChunks.getFS(Configuration, String) | CORRECTNESS | NP_ALWAYS_NULL | 68 | High |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.DumpChunks.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 48 | High |
org.apache.hadoop.chukwa.util.DumpChunks$DumpAndSummarize
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.util.DumpChunks$DumpAndSummarize.updateMatchCatalog(String, ChunkImpl) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 219 | Medium |
| Method org.apache.hadoop.chukwa.util.DumpChunks$DumpAndSummarize.updateMatchCatalog(String, ChunkImpl) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 220 | Medium |
org.apache.hadoop.chukwa.util.DumpRecord
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.DumpRecord.main(String[]) | CORRECTNESS | NP_ALWAYS_NULL | 39 | High |
org.apache.hadoop.chukwa.util.PidFile
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.apache.hadoop.chukwa.util.PidFile(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 58 | Medium |
| org.apache.hadoop.chukwa.util.PidFile.init() invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 100 | Medium |
| Null pointer dereference of System.out in org.apache.hadoop.chukwa.util.PidFile.init() | CORRECTNESS | NP_ALWAYS_NULL | 97 | High |
| org.apache.hadoop.chukwa.util.PidFile.<static initializer>() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 42 | Medium |
| org.apache.hadoop.chukwa.util.PidFile.<static initializer>() ignores exceptional return value of java.io.File.mkdir() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 44 | Medium |
| Write to static field org.apache.hadoop.chukwa.util.PidFile.lock from instance method org.apache.hadoop.chukwa.util.PidFile.init() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 90 | Medium |
| Write to static field org.apache.hadoop.chukwa.util.PidFile.pidFileOutput from instance method org.apache.hadoop.chukwa.util.PidFile.init() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 86 | Medium |
org.apache.hadoop.chukwa.util.TempFileUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.hadoop.chukwa.util.TempFileUtil.makeBinary(int) may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 37 | Medium |